Allow accessing fields with a method of the same name #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,10 @@ public static function getObjectFieldValue($object, string $field) | |||
| return $object[$field]; | |||
| } | |||
|
|
|||
| if (method_exists($object, $field)) { | |||
There was a problem hiding this comment.
method_exists also returns true if the method is not public.
https://3v4l.org/LAgYk
There was a problem hiding this comment.
Exactly the same as it works without my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a matching over a criteria lead me to an error that I cannot access the field. I then discovered the run lacks checking the object for methods with the same name as the field has. I find it a common practice to ommit the get keyword in getter methods. Thus this PR