Enforce no BC breaks against v1.5.0 #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it cannot be done because the lib requires php 7.2 and this package is supposed to be compatible with 7.1 |
|
Can bump the PHP version, if needed for |
|
I like the idea! Regarding your first sentence, did you mean UPDATE: 1.6.0 was released when I was typing the sentence above, I understand now :) |
Majkl578
suggested changes
Apr 10, 2019
| - stage: Backwards Compatibility | ||
| env: STATIC_ANALYSIS | ||
| install: travis_retry composer install --prefer-dist | ||
| script: vendor/bin/roave-backward-compatibility-check --from=v1.5.0 |
There was a problem hiding this comment.
Hardcoding tag name here is not a good idea, can we use some kind of wildcard, like latest 1.x tag?
|
I agree with not bumping requirement because of dev dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly a good idea for branches in
1.x, not to be merged intomaster? Just throwing it out there: this would prevent most feedback along the lines of "we can't do that because BC" from human-to-human, which is frustrating.