Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forms] Fix PhpcrOdmQueryBuilderLoader and depend on symfony version that fixed DoctrineType #201

Merged
merged 1 commit into from
May 22, 2015
Merged

[Forms] Fix PhpcrOdmQueryBuilderLoader and depend on symfony version that fixed DoctrineType #201

merged 1 commit into from
May 22, 2015

Conversation

lsmith77
Copy link
Member

supersedes #193

@lsmith77 lsmith77 mentioned this pull request May 20, 2015
Closed
@lsmith77 lsmith77 added review and removed wip/poc labels May 20, 2015
dantleech
dantleech reviewed May 21, 2015
View reviewed changes
Form/ChoiceList/PhpcrOdmQueryBuilderLoader.php
foreach ($values as $val) {
$qb->orWhere()->eq()->field($alias.'.'.$identifier)->literal($val);
$where->same($val, $alias);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this would just overwrite the value on the same criteria several times would it not? Shouldnt the ->orX be in the loop?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, i think you are right dan. @lsmith77 can you maybe add a second document to the fixtures and test with one and two ids? Right now we dont test that we actually filter vs just loading all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't appear to be the case. I have added another document to the fixtures and it seems to just work ..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs seem to agree as well http://doctrine-phpcr-odm.readthedocs.org/en/latest/reference/query-builder-reference.html#qbref-method-constraintfactory-orx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, your right.

@lsmith77
Copy link
Member Author

we only get this error on 2.4 .. why don't we get it on 2.3?

[ReflectionException]                                                        
  Class Symfony\Component\HttpKernel\EventListener\SaveSessionListener does n  
  ot exist

@lsmith77
Copy link
Member Author

goody .. all green

lsmith77 added a commit that referenced this pull request May 22, 2015
@lsmith77
Merge pull request #201 from doctrine/fix_form_type
d7c4e55 
[Forms] Fix PhpcrOdmQueryBuilderLoader and depend on symfony version that fixed DoctrineType
@lsmith77 lsmith77 merged commit d7c4e55 into 1.2 May 22, 2015
@lsmith77 lsmith77 removed the review label May 22, 2015
@lsmith77 lsmith77 deleted the fix_form_type branch May 22, 2015 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lsmith77 @dbu @stof @dantleech @uwej711