-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the ManagerRegistry service configurable #165
Conversation
-1 for exposing it in the semantic config. It is a complex edge case, and the custom class might require more changes than just the class name (more dependencies to determine the manager for instance). IMO, people wanting this should either overwrite the parameter themselves directly, or use a compiler pass to edit the definition if they need more stuff (or use the new |
What if instead of the specifying the class name we specify the service ID? We can then use an alias to define |
in some places we allow configuring class names and in others services. both works for me i guess. but what else would you want to inject given that the registry has access to the container? |
don't know - but you have the option of not injecting the container I guess. |
@stof well we were saying this is the solution for be able to do stuff like switching elegantly between a staging and production workspace. as such it is not such an edge case for quite a few CMS. but ok lets make the service configurable rather than the class. |
3b42cb3
to
c4da9de
Compare
done |
'dump_max_line_length', | ||
'workspace_dir' => 'workspace_dir', | ||
'jackrabbit_jar' => 'jackrabbit_jar', | ||
'dump_max_line_length' => 'dump_max_line_length', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you expand these? its not adding anything. i can live with it, just don't see why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. this was from a previous version of the patch. will remove
+1 on the way its done now, allowing to specify the service id for full customization. user can still use the di container parameter if he just needs a different class. |
c4da9de
to
c003b58
Compare
make the ManagerRegistry service configurable
thanks. created symfony-cmf/symfony-cmf-docs#558 so we don't forget about the doc. |
fix for #73