Update doc for dependencies injection and Symfony 7 #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Nov 7, 2024
derrabus
requested changes
Nov 7, 2024
Resources/doc/index.rst
Outdated
Comment on lines
302
to
303
| The interface ``Symfony\Component\DependencyInjection\ContainerAwareInterface`` has been deprecated in Symfony 6.4 and | ||
| removed in 7.0. If you use this version or newer, there is currently no way to inject dependencies in migrations. |
There was a problem hiding this comment.
I might be nit-picking here, but there has never been a way to inject dependencies into migrations. It was the service container that was injected.
|
Updated according to Derrabus review |
SenseException
approved these changes
Nov 7, 2024
derrabus
approved these changes
Nov 7, 2024
| .. caution:: | ||
|
|
||
| The interface ``Symfony\Component\DependencyInjection\ContainerAwareInterface`` has been deprecated in Symfony 6.4 and | ||
| removed in 7.0. If you use this version or newer, there is currently no way to inject service container in migrations. |
There was a problem hiding this comment.
Suggested change
| removed in 7.0. If you use this version or newer, there is currently no way to inject service container in migrations. | |
| removed in 7.0. If you use this version or newer, there is currently no way to inject the service container into migrations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #521
Update doc to mention this interface is no longer available starting from SF 7+
Considering this bundle can be used with older versions I think this isn't necessary to remove this part as it can be useful for some projects