Added condition to check that we have an active connection #474
Conversation
| } | ||
|
|
||
| public function collect(Request $request, Response $response, \Throwable $exception = null) | ||
| public function collect(Request $request, Response $response, ?Throwable $exception = null) |
There was a problem hiding this comment.
Please note that running phpcbf is adding return type.
It's hard to reproduce this scenario in CI, as we need to boot entire application (without configured dbal connection) and I haven't found any "functional tests" for this bundle. |
|
@derrabus any chance that you'll be able to take a look at this? |
|
@derrabus Whats problem? |
|
I'm sorry that nobody has picked up this PR after my initial triage. I still don't fully understand why problem is solved here. The collector needs a valid database connection. And without one, this whole bundle doesn't make much sense. |
It's been awhile, let me remember.
IIRC initial problem is/was with clean project, when database is not yet configured. and it's not very obvious that something is wrong and developers start digging into a problem why clean project is taking 30s to load. At least this is what I remember. |
|
^^^ and the idea was: avoid collecting migrations if connection is not configured. |
|
and PR that was trying to fix similar issue: #428 just wrapped code with try/catch which does not prevent of trying to make a connection |
Fixes #473