Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(githubCorner): add width and height attributes #1992

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dpschen
Copy link

@dpschen dpschen commented Feb 17, 2023

Summary

Add width and height attribute.
This fixes jumping of the SVG for loading for slow connections.

Here is a video showing this behavior for the zod documentation:

Screen.Recording.2023-02-17.at.14.55.08.mp4

This adds width and height attributes to the github corner svg so that the intrinsic size is defined. See also https://web.dev/optimize-cls/#modern-best-practice. This does not prevent overwriting the size via CSS later so it shouldn't break any user CSS.

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Add width and height attribute.
This fixes jumping of the SVG for loading for slow connections.
@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2023 9:13pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 43e3109:

Sandbox Source
docsify-template Configuration

@Koooooo-7 Koooooo-7 added the ui/ux related to user interface and/or user experience of docsify label Feb 20, 2023
@Koooooo-7 Koooooo-7 requested a review from a team February 20, 2023 10:46
@trusktr
Copy link
Member

trusktr commented Jul 9, 2023

Tests are not running for some reason.

@trusktr trusktr changed the base branch from develop to main July 9, 2023 21:12
@trusktr trusktr changed the base branch from main to develop July 9, 2023 21:13
@trusktr
Copy link
Member

trusktr commented Jul 9, 2023

Changing bases to main and back to develop fixed it (same issue I've had in other projects, changing base always works).

@trusktr
Copy link
Member

trusktr commented Jul 9, 2023

This will conflict with

We'll merge that one first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux related to user interface and/or user experience of docsify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants