Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed buttons settings issue [#21] by making settings more specific. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed buttons settings issue [#21] by making settings more specific. #22

wants to merge 1 commit into from

Conversation

inspired-io
Copy link

I changed buttons to socialButtons and added serviceBadges.

Original issue here: #21

@RobLoach
Copy link
Contributor

RobLoach commented Mar 3, 2014

Looks pretty good... If we update the tests, it should be good to go.

@inspired-io
Copy link
Author

Hi @RobLoach, I'm on vacation until next week. Will update tests then and resubmit PR.

@mikeumus
Copy link
Member

Hey @inspired-io, thanks for this awesome PR. Wanted to follow up on it with you. Hope you had an awesome vacation 😉 .

balupton
balupton approved these changes Apr 17, 2017 •
edited
Loading
View reviewed changes
balupton
balupton reviewed Apr 17, 2017
View reviewed changes
Copy link
Member

@balupton balupton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a breaking change, will need to wait until semver plugins happen

@balupton
Copy link
Member

balupton commented Aug 1, 2019

I have become too preoccupied by other things to review, merge, and release this PR.

However, you should have received an invite a while ago to join the DocPad Extras Team, which will give you write access to this repository, so you can merge in the PR.

For an orientation, or if you need any assistance following the semi-automatic release process from CONTRIBUTING.md, reach out via https://bevry.me/discord/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balupton balupton balupton approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inspired-io @RobLoach @mikeumus @balupton