-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: begin lua-side stdlib, implement combinators & validators. also, beginning of docs, and add build, test, and rustfmt to CI #5
Conversation
3e6f2c3
to
7fbcb4c
Compare
5b4f518
to
3cd0b80
Compare
3cd0b80
to
9d0f2bf
Compare
316bd18
to
2156e70
Compare
acec95d
to
b031451
Compare
b031451
to
b063a27
Compare
examples/simpleish/seatrial.lua
Outdated
@@ -10,6 +12,15 @@ function generate_30_day_range() | |||
} | |||
end | |||
|
|||
function was_valid_esoteric_format(arg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nitty q - do you have strong opinions on was
vs is
prefix for boolean functions? I'm used to seeing is_
but as per usual my only real preference is to have a convention, regardless of what that convention is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, I suppose I never gave this thought, but since the data isn't dead yet (bring out yer dead.....), is
is probably more appropriate, even though the request happened in the past by the time it gets to this function
Holy guacamole, this came out to many more lines of code than I expected...
Included here are:
ValidationResult
enum, enabling user scripts to do custom validations on, say, response bodies (see updatedseatrial.lua
for usage example; manual pages are TODO)rustfmt
(plus still run clippy). this should be enough CI to automate regression testing, now that I've started adding unit tests here and there. it also resolves all style guide questions going forward, now that the application has more than one author 😃refs #1