Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Fix for #2989 #4770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for #2989 #4770

wants to merge 1 commit into from

Conversation

olivbour
Copy link

Description

A user member of "Hyper-V Administrators" group should be able to create a VM without also being member of "Administrators" group.

For using an SID as parameter - which is better because of potential i18n issue with role name - "isInRole()" expect a "System.Security.Principal.SecurityIdentifier" object instead of a "String".

That's because of this error that isHypervAdministrator() always return false and and consequently "Administrator" role is requested.

Related issue(s)

#2989

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-2" [email protected]:olivbour/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

For using an SID as parameter - which is better because of potential i18n issue with role name - "isInRole()" expect a "System.Security.Principal.SecurityIdentifier" object instead of a "String".

That's because of this error that isHypervAdministrator() always return false and and consequently  "Administrator" role is requested.

Signed-off-by: Olivier Bourgeat <[email protected]>
@stylobille
Copy link

Hello,

We are really waiting for a fix on this issue (giving everybody in the company administrator rights is not possible). Since the fix has already been coded, thanks to @olivbour, how much time will it take to see this in docker desktop ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants