Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2324 #21475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ENGDOCS-2324 #21475

wants to merge 1 commit into from

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Nov 20, 2024

Description

Light freshness for ECI content and removes references to DD versions that users can no longer download

Note There is a lot of 'allow' violations. Am deliberately choosing to ignore them this time.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit fd1239c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/673de816ad46c400081bcaac
😎 Deploy Preview https://deploy-preview-21475--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


These techniques include:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have remove this from the top because it is repeated in more detail down below

@aevesdocker aevesdocker marked this pull request as ready for review November 20, 2024 14:10
@aevesdocker aevesdocker requested a review from a team November 20, 2024 14:10
Sysdig
Testcontainers
Traefik
Ubuntu
Unix
VMware
VM's
Copy link
Collaborator

@dvdksn dvdksn Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do this instead, in the beginning of this file, to never flag possessive form of acronyms (e.g., SDK's, API's)

-(?-i)[A-Z]{2,}s
+(?-i)[A-Z]{2,}'?s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants