Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize repo linked in Compose section is no longer maintained #13548

Closed
KeithScheiwiller opened this issue Sep 16, 2021 · 1 comment · Fixed by #13549
Closed

Dockerize repo linked in Compose section is no longer maintained #13548

KeithScheiwiller opened this issue Sep 16, 2021 · 1 comment · Fixed by #13549

Comments

@KeithScheiwiller
Copy link

KeithScheiwiller commented Sep 16, 2021

Problem description

The repo linked to in compose/startup-order.md, jwilder/dockerize no longer seems to be maintained, see jwilder/dockerize#147. In its current state, it has several issues and no updates have been pushed since 2018. To even build from source you will need to pull in a few patches from the PRs

A maintained fork of the project has been created at https://github.com/powerman/dockerize.
jwilder has expressed jwilder/dockerize#120 (comment) that they do not agree with the procedures and approaches of the fork, so some investigation could be warranted. I personally am not familiar enough with the tool to know myself. I think it is a very valuable tool for the ecosystem, but I'd like to save others from the headaches I encountered from stumbling across it in the docs and attempting to use it.

Problem location

URL: https://docs.docker.com/compose/startup-order/

Project version(s) affected

N/A

Suggestions for a fix

In my opinion, it should either be updated to the fork at powerman/dockerize or removed entirely.

PR with the former solution linked below

usha-mandya added a commit that referenced this issue Oct 8, 2021
#13548 Update Dockerize repo URL from jwilder/dockerize->powerman/dockerize
FelicianoTech added a commit to CircleCI-Public/cimg-base that referenced this issue Sep 20, 2022
Fixes #198 

This Dockerize update is mainly being done in preparation for upcoming
arm64 image support. The current version we were using was amd64 only.
Diving a bit deeper though...

The version of Dockerize we've been using has been stuck in time. For
two reasons. 1) The original project,
https://github.com/jwilder/dockerize, is no longer maintained. So there
hasn't been new releases. 2) We were using a release from the project
stored in our S3 bucket.

We're switching to a fork that has been accepted by many on the
community. Relevant is this [GitHub
Issue](docker/docs#13548) in the
official Docker Docs as well as this [follow up
PR](docker/docs#13549) that actually
makes the suggestion change over to this newer project. We're switching
to this fork.

v0.8.0 was chosen for a specific reason. I don't want to jump straight
to v0.16.3 in case there are breaking changes we're not aware of. I
rather ease into that change over time. I wanted to use a version much
closer to v0.6.1 from the original project. v0.8.0 of the fork is the
closest version that was also compiled for arm64, which we need.
@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants