Upgrade Dockerize to v0.8.0 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
This Dockerize update is mainly being done in preparation for upcoming arm64 image support. The current version we were using was amd64 only. Diving a bit deeper though...
The version of Dockerize we've been using has been stuck in time. For two reasons. 1) The original project, https://github.com/jwilder/dockerize, is no longer maintained. So there hasn't been new releases. 2) We were using a release from the project stored in our S3 bucket.
We're switching to a fork that has been accepted by many on the community. Relevant is this GitHub Issue in the official Docker Docs as well as this follow up PR that actually makes the suggestion change over to this newer project. We're switching to this fork.
v0.8.0 was chosen for a specific reason. I don't want to jump straight to v0.16.3 in case there are breaking changes we're not aware of. I rather ease into that change over time. I wanted to use a version much closer to v0.6.1 from the original project. v0.8.0 of the fork is the closest version that was also compiled for arm64, which we need.