Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify options for secret types (file, env) #2740

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Oct 16, 2024

Improve descriptions of the attributes for the --secret flag for buildx build.

  • Clarify how buildx determines whether to use type=file or type=env.
  • Clarify that relative filepaths for type=file are calculated based on CWD where the buildx command is executed.
  • Add src and source as possible attributes for type=env, but clarify that they require type=env to be set explicitly if you want to source from an env var (otherwise type=file is assumed).

Related issues

@dvdksn
Copy link
Contributor Author

dvdksn commented Oct 16, 2024

check failures are unrelated, but would be nice to make sure validate-docs can run;

ERROR: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 502 Bad Gateway

I lack permissions to restart the failed jobs.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@tonistiigi tonistiigi merged commit 8d32cab into docker:master Oct 16, 2024
28 checks passed
@dvdksn dvdksn deleted the src-attr-secret-env branch October 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secret handling documentation for env missing attribute keys
3 participants