Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker(install): use undock to extract image #567

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crazy-max
Copy link
Member

follow-up #438 (review)

@crazy-max crazy-max force-pushed the docker-install-undock branch 3 times, most recently from b28bf20 to e8696b0 Compare January 19, 2025 22:28
@crazy-max crazy-max force-pushed the docker-install-undock branch from 5b7e44a to dfe64a3 Compare January 19, 2025 23:07
@crazy-max
Copy link
Member Author

crazy-max commented Jan 20, 2025

Hum on macOS, buildx is not available so we can't use the imagetools command to get the image config for lima: https://github.com/docker/actions-toolkit/actions/runs/12857983316/job/35846515916?pr=567#step:10:51

FAIL __tests__/docker/install.test.itg.ts (20.152 s)
  ● Console

    console.error
      Error: Unable to locate executable file: buildx. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.
          at Object.<anonymous> (/Users/runner/work/actions-toolkit/actions-toolkit/node_modules/@actions/io/src/io.ts:170:15)
          at Generator.next (<anonymous>)
          at fulfilled (/Users/runner/work/actions-toolkit/actions-toolkit/node_modules/@actions/io/lib/io.js:24:58)

moby/moby#49301 could solve this issue so we don't require buildx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant