Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Solr - Fix 8.11.2 URLs, and improve other version URLs (apache/solr-docker#17) #16134

Merged

Conversation

docker-solr-builder
Copy link

Apache Solr:

Fix 8.11.2 URLs, and improve other version URLs (apache/solr-docker#17)

See apache/solr-docker@e383a55 for the triggering commit.

Relevant Maintainers: @HoustonPutman @janhoy @dsmiley @madrob

This is an automated PR based on a change made in the https://github.com/apache/solr-docker repository's main branch.

@HoustonPutman
Copy link
Contributor

+1 approved

Copy link

Diff for 4b28f91:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 3449572..ff5e67d 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,48 +1,48 @@
-Maintainers: The Apache Solr Project <[email protected]> (@asfbot), David Smiley (@dsmiley), Jan Høydahl (@janhoy), Houston Putman (@houstonputman)
+Maintainers: The Apache Solr Project <[email protected]> (@asfbot), Shalin Mangar (@shalinmangar), David Smiley (@dsmiley), Jan Høydahl (@janhoy), Houston Putman (@houstonputman)
 GitRepo: https://github.com/apache/solr-docker.git
 GitFetch: refs/heads/main
 
 Tags: 8.11.2, 8.11, 8
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 8.11
 
 Tags: 8.11.2-slim, 8.11-slim, 8-slim
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 8.11-slim
 
 Tags: 9.0.0, 9.0
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 9.0
 
 Tags: 9.1.1, 9.1
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 9.1
 
 Tags: 9.2.1, 9.2
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 9.2
 
 Tags: 9.3.0, 9.3
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 9.3
 
 Tags: 9.3.0-slim, 9.3-slim
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 9.3-slim
 
 Tags: 9.4.1, 9.4, 9, latest
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 9.4
 
 Tags: 9.4.1-slim, 9.4-slim, 9-slim, slim
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: e743474ec59206f53e6c1003cc852f104b315d43
+GitCommit: e383a5513c30d1ff663cbb57a45134d5c407147f
 Directory: 9.4-slim
diff --git a/solr_8-slim/Dockerfile b/solr_8-slim/Dockerfile
index dd596fd..36d3663 100644
--- a/solr_8-slim/Dockerfile
+++ b/solr_8-slim/Dockerfile
@@ -28,8 +28,8 @@ ENV SOLR_USER="solr" \
     SOLR_UID="8983" \
     SOLR_GROUP="solr" \
     SOLR_GID="8983" \
-    SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?filename=lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz&action=download" \
-    SOLR_DIST_URL="https://www.apache.org/dist/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz" \
+    SOLR_CLOSER_URL="https://www.apache.org/dyn/closer.lua/lucene/solr/${SOLR_VERSION}/solr-${SOLR_VERSION}.tgz?action=download" \
+    SOLR_DIST_URL="https://downloads.apache.org/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz" \
     SOLR_ARCHIVE_URL="https://archive.apache.org/dist/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz" \
     PATH="/opt/solr/bin:/opt/docker-solr/scripts:$PATH" \
     SOLR_INCLUDE=/etc/default/solr.in.sh \
diff --git a/solr_8/Dockerfile b/solr_8/Dockerfile
index 035afdb..b8c34b9 100644
--- a/solr_8/Dockerfile
+++ b/solr_8/Dockerfile
@@ -28,8 +28,8 @@ ENV SOLR_USER="solr" \
     SOLR_UID="8983" \
     SOLR_GROUP="solr" \
     SOLR_GID="8983" \
-    SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?filename=lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz&action=download" \
-    SOLR_DIST_URL="https://www.apache.org/dist/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz" \
+    SOLR_CLOSER_URL="https://www.apache.org/dyn/closer.lua/lucene/solr/${SOLR_VERSION}/solr-${SOLR_VERSION}.tgz?action=download" \
+    SOLR_DIST_URL="https://downloads.apache.org/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz" \
     SOLR_ARCHIVE_URL="https://archive.apache.org/dist/lucene/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz" \
     PATH="/opt/solr/bin:/opt/docker-solr/scripts:$PATH" \
     SOLR_INCLUDE=/etc/default/solr.in.sh \
diff --git a/solr_9.0/Dockerfile b/solr_9.0/Dockerfile
index b91f112..a03fc00 100644
--- a/solr_9.0/Dockerfile
+++ b/solr_9.0/Dockerfile
@@ -33,7 +33,7 @@ ARG SOLR_DOWNLOAD_SERVER
 
 # These should never be overridden except for the purposes of testing the Dockerfile before release
 ARG SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?action=download&filename=/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
-ARG SOLR_DIST_URL="https://www.apache.org/dist/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
+ARG SOLR_DIST_URL="https://downloads.apache.org/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
 ARG SOLR_ARCHIVE_URL="https://archive.apache.org/dist/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
 
 RUN set -ex; \
diff --git a/solr_9.1/Dockerfile b/solr_9.1/Dockerfile
index eab4939..6a58bf0 100644
--- a/solr_9.1/Dockerfile
+++ b/solr_9.1/Dockerfile
@@ -33,7 +33,7 @@ ARG SOLR_DOWNLOAD_SERVER
 
 # These should never be overridden except for the purposes of testing the Dockerfile before release
 ARG SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?action=download&filename=/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
-ARG SOLR_DIST_URL="https://www.apache.org/dist/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
+ARG SOLR_DIST_URL="https://downloads.apache.org/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
 ARG SOLR_ARCHIVE_URL="https://archive.apache.org/dist/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
 
 RUN set -ex; \
diff --git a/solr_9.2/Dockerfile b/solr_9.2/Dockerfile
index a360ac3..597dd17 100644
--- a/solr_9.2/Dockerfile
+++ b/solr_9.2/Dockerfile
@@ -33,7 +33,7 @@ ARG SOLR_DOWNLOAD_SERVER
 
 # These should never be overridden except for the purposes of testing the Dockerfile before release
 ARG SOLR_CLOSER_URL="http://www.apache.org/dyn/closer.lua?action=download&filename=/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
-ARG SOLR_DIST_URL="https://www.apache.org/dist/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
+ARG SOLR_DIST_URL="https://downloads.apache.org/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
 ARG SOLR_ARCHIVE_URL="https://archive.apache.org/dist/solr/solr/$SOLR_VERSION/solr-$SOLR_VERSION.tgz"
 
 RUN set -ex; \

Relevant Maintainers:

@janhoy
Copy link
Contributor

janhoy commented Jan 25, 2024

+1

@yosifkit
Copy link
Member

And welcome to the new Solr image maintainer, @shalinmangar 🎉 🎊

@yosifkit yosifkit merged commit b9843a1 into docker-library:master Jan 25, 2024
14 checks passed
@dsmiley
Copy link
Contributor

dsmiley commented Jan 25, 2024

Why was Shalin added? I removed him a week ago

@yosifkit
Copy link
Member

Why was Shalin added? I removed him a week ago

It looks like they are still in the generator script that the bot used.

@tianon
Copy link
Member

tianon commented Jan 25, 2024

#16114 (comment) relevant here too 😄

It might be worth considering (in the future) switching to the Apache CDN explicitly: https://www.apache.org/mirrors 👀

(I only just noticed this change myself last week 😅 ❤️)

See also docker-library/tomcat#308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants