Skip to content

Commit

Permalink
Rewrite deploy to minimize API requests (#38)
Browse files Browse the repository at this point in the history
* WIP: first pass at deploy

* WIP: second pass, now with more cowbell

* WIP: refactor coverage handling (cleaner, more consistent, no longer has to clobber top-level bin/)

* WIP: the start of more "jq" tests

* WIP: add a few TODOs

* Add a benchmark for `om.OrderedMap.Set`

I was testing a minor memory-usage improvement to `Set`, but it turns out it doesn't actually matter (and this helped me determine that, so I might as well keep it).

* Add explicit `Reference.StringWithKnownDigest` unit test

* WIP: refactor EnsureManifest loop with more correct handling of child manifests vs blobs

* Update to use the new `ociregistry.HTTPError` for more consistent/correct HTTP error handling

* WIP: remove TODO that was implemented elsewhere (and fix error message text / comment text)

* WIP: also normalize descriptor field ordering

* WIP: assume pre-normalized platform (no reason to normalize more than once)

* WIP: initial "deploy" data munging helpers plus tests

* WIP: update Jenkinsfile.deploy to use new deploy code

* WIP: remove example-commands symlink so Git detects rename better

* WIP: add delay for racy registry startup

* WIP: remove trap once it's no longer necessary

* WIP: typo

* WIP: remove unnecessary TODOs
  • Loading branch information
tianon authored Apr 18, 2024
1 parent 530a108 commit ab38f95
Show file tree
Hide file tree
Showing 35 changed files with 5,362 additions and 85 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,13 @@ jobs:
chmod +x .bin/bashbrew
.bin/bashbrew --version
echo "$PWD/.bin" >> "$GITHUB_PATH"
- run: .test/test.sh
- run: .test/test.sh --deploy
- uses: actions/upload-artifact@v4
with:
name: coverage
path: .test/coverage**
path: |
.test/.coverage/coverage.*
.test/.coverage/GOCOVERDIR/
if-no-files-found: error
- name: gofmt
run: find -name '*.go' -type f -exec ./.go-env.sh gofmt -l -s -w '{}' +
Expand Down
3 changes: 3 additions & 0 deletions .test/.coverage/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**
!.gitignore
!builds.sh
1 change: 1 addition & 0 deletions .test/.coverage/builds.sh
1 change: 1 addition & 0 deletions .test/deploy-all/in.json
Loading

0 comments on commit ab38f95

Please sign in to comment.