Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve explanation about how to customize Nginx configuration #2369

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

DQNEO
Copy link
Contributor

@DQNEO DQNEO commented Sep 19, 2023

First of all, thank you for the great effort to maintain this marvelous project.

When I first saw this document, I didn't understand the meaning of This can also be accomplished.
I actually misinterpreted it as "Copying the default nginx configuration file from a running container to the host system can also be accomplished" , but the docker file looked doing the opposite.

So I tried to improve some points:

  • "copying the default conf" relates to both mounting and building , so I moved it to the head
  • It is not necessarily "complex", so I omitted it.

@DQNEO DQNEO changed the title Improve explanation on how to customize nginx conf Improve explanation about how to customize Nginx configuration Sep 19, 2023
@DQNEO DQNEO marked this pull request as ready for review September 19, 2023 16:55
@yosifkit
Copy link
Member

Seems ok to me (minus the minor fix to make the markdown formatter happy).

cc the nginx image maintainer: @thresheek to make sure they are ok with content.

@thresheek
Copy link
Contributor

Thanks @yosifkit - I think the change is good.

When I first saw this document, I didn't understand the meaning of 'This can also be accomplished' and it confused me. 
So, I suggest an improvement.
@DQNEO
Copy link
Contributor Author

DQNEO commented Oct 11, 2023

I've fix the markdown format.

@LaurentGoderre LaurentGoderre merged commit 6779ba2 into docker-library:master Oct 24, 2023
5 checks passed
@DQNEO DQNEO deleted the patch-1 branch December 31, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants