Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about versions and breaking changes #1658

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mltsy
Copy link

@mltsy mltsy commented Feb 21, 2020

This PR can be considered an alternative to docker-library/postgres#689

I don't know whether it makes more sense to add the warning here or there. In either case, one should probably link to the other, for the full description.

Note: I added the warning text at the very top of the file mostly because the contents of this file appear directly below the "supported tags" section of the README after templates are applied... if there's a better way to arrange this, I'm open to suggestions, obviously ;)

@tianon
Copy link
Member

tianon commented Feb 28, 2020

I agree it would be good to document this better; thanks for taking a first pass!

That being said, I don't think a specific image is the right place for it -- I think our FAQ is probably a better place, since it's really a generic thing across all the official images: https://github.com/docker-library/faq

@mltsy
Copy link
Author

mltsy commented Mar 4, 2020

@tianon That would be great! Although that buries it a little bit...

I'm torn on this because, as much as I would love to believe that everyone knows to RTFM before using new technology - in practice, I know a lot of people (including me) come to Docker not as a "student of new technology", but because they are working in places it's already implemented, and make what seem like "reasonable" assumptions until something breaks. This particular issue does (at least to some degree) violate "reasonable assumptions" in a way that can surprise you by breaking a production environment when you least expect it, so it seems important to have more visible as a warning. The docs for a particular image seem much more visible and likely to be read and/or referenced when something goes wrong with an image than the docs for the docker official images library as a whole. But that's just my opinion... still open to suggestions.

Maybe a good compromise would be to add this documentation to the main FAQ or overview, and then allow image maintainers to put a note/link to that section (for visibility)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants