Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore the exit code of modprobe always #468

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Ignore the exit code of modprobe always #468

merged 3 commits into from
Jan 5, 2024
+99 −12

Commits on Jan 4, 2024

  1. Ignore the exit code of modprobe always 

    The nature of `modprobe` in this image is that it works via `ip` hacks, but the exit code will always be non-zero because we don't have `/lib/modules` from the host.

The effect of this was that everyone was using `iptables-legacy` (whether it was warranted for them to be doing so or not).
    @tianon
    tianon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    da22584 View commit details
    Browse the repository at this point in the history

  2. Use /proc/net/ip_tables_names (and friends) to pre-detect whether w… 

    …e should use `iptables-legacy`
    @tianon
    tianon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d5d05eb View commit details
    Browse the repository at this point in the history

  3. Add DOCKER_IPTABLES_LEGACY for letting users explicitly pick `iptab… 

    …les-legacy`

via `--env DOCKER_IPTABLES_LEGACY=1`
    @tianon
    tianon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    eb4c40e View commit details
    Browse the repository at this point in the history