Update to Alpine 3.19 #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, #437 by itself is not correct/complete, but it is a great thing to surface and a big problem for this image (surfacing a larger problem with iptables vs nftables, especially as it relates to network namespaces / Docker-in-Docker). 😞 |
|
That seems like a rather large blocking issue then. I'll mark this as draft in the meantime, so anyone interested can still subscribe and track progress. |
https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/47102 changes the default iptables backend to nf_tables. To prepare for the change (and to make sure it's not forgotten once DinD is updated), load nf_tables into the kernel.
jnoordsij
force-pushed
the
update-alpine-3.19
branch
from
0c7cceb
to
18bbfb7
Compare
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 14, 2023
Changes: - docker-library/docker@0411c8f: Merge pull request docker-library/docker#461 from jnoordsij/update-alpine-3.19 - docker-library/docker@18bbfb7: Update to Alpine 3.19 - docker-library/docker@4c2674d: Remove ip_tables in favor of nf_tables in dockerd entrypoint fallback - docker-library/docker@07fb6c2: Load nf_tables in preparation of Alpine 3.19
akerouanton
added a commit
to akerouanton/docker-doi
that referenced
this pull request
Dec 15, 2023
PR docker-library#461 updated Alpine to 3.19 and made a change to load the nf_tables kernel module if needed. However, as demonstrated by docker-library#463 and docker-library#464 this might break when the host system doesn't have the nf_tables module available. In that case, we should still try to load the ip_tables module and symlink /sbin/iptables to xtables-legacy-multi. Signed-off-by: Albin Kerouanton <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Alpine to the latest stable version: 3.19.
See also https://alpinelinux.org/posts/Alpine-3.19.0-released.html.
Edit: This is currently blocked as it requires additional upstream support for
nftables; see also comment below and #437.Closes: #437