Add missing Py_DECREF to error handling #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gadgetoid, have you tested this enough to feel confident including it in the next release? |
|
@doceme yes- I have had a number of customers install the modified version of the library and report that it fixed their issue. No other side-effects have (yet) been reported. I've also run it with success for some time, albeit I had to move on to other things since. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix all of the issues I've found in #95 so far. However; It's by no means a comprehensive review of memory/reference counting issues.
For sequence length checking I have adopted the method used in
xfer3by @dimas where the length and sequence validity checks are separated since only the former requires a DECREF call.