Create CertificatePrivateKey class instead of combining into CertificateBundle #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
self-requested a review
added 2 commits
March 12, 2024 11:11
ggalmazor
force-pushed
the
change/create-separate-class-for-certificate-private-key
branch
from
2247e80
to
57305f7
Compare
|
Closing in favor of #171 I wanted to reduce the number of breaking changes introduced by this fix, so I avoided changing the getters in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we return CertificateBundle for both downloadCertificate and getCertificatePrivateKey, despite not having any shared data. Move the private key data into its own class. This is a breaking change. Fixes #118. We'll postpone merging until the next major version; if we merge it now, our next release must be breaking, even if the other changes are only patches or minor.