Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to dart sass #605

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Move to dart sass #605

wants to merge 9 commits into from

Conversation

sbastn
Copy link
Member

@sbastn sbastn commented May 9, 2024

This PR removes Sass in favor of Dart Sass.

Closes #175

QA

  1. rake run
  2. Open site
    • Layout, colors and font should match developer.dnsimple.com
    • Search a topic: matches developer.dnsimple.com
    • Browse an article: matches developer.dnsimple.com

@sbastn sbastn self-assigned this May 9, 2024
@sbastn sbastn added dependencies Pull requests that update a dependency file task One or more no-coding actions to execute for this project. labels May 9, 2024
@sbastn sbastn requested review from dperrymorrow and dallasread May 9, 2024 15:36
dperrymorrow
dperrymorrow approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@dperrymorrow dperrymorrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the preview looks like it failed to build, is that related to the gem change?

@sbastn
Copy link
Member Author

sbastn commented May 20, 2024

the preview looks like it failed to build, is that related to the gem change?

Yes. Something is wrong with the gem. The PR is not ready for review yet.

@weppos weppos marked this pull request as draft May 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dperrymorrow dperrymorrow dperrymorrow approved these changes

Assignees

@sbastn sbastn

Labels
dependencies Pull requests that update a dependency file task One or more no-coding actions to execute for this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby Sass is deprecated
2 participants
@sbastn @dperrymorrow