Migraines return errors for proper rollbacks

runner/migraine.go

@@ -4,10 +4,12 @@ import (
 	"github.com/jinzhu/gorm"
 )
 
+type performFn func(*gorm.DB) error
+
 type Migraine struct {
-	DisableDDL bool           `gorm:"-"`
-	Perform    func(*gorm.DB) `gorm:"-"`
-	Version    string         `gorm:"size:255;PRIMARY_KEY;NOT NULL"`
+	DisableDDL bool      `gorm:"-"`
+	Perform    performFn `gorm:"-"`
+	Version    string    `gorm:"size:255;PRIMARY_KEY;NOT NULL"`
 }
 
 func (m Migraine) Run(db *gorm.DB) {
@@ -16,11 +18,16 @@ func (m Migraine) Run(db *gorm.DB) {
 		tx = db
 	} else {
 		tx = db.Begin()
+		defer tx.Commit()
+	}
+
+	if err := m.Perform(tx); err != nil {
+		tx.Rollback()
+		panic(err)
 	}
-	defer tx.Commit()
-	m.Perform(tx)
 
 	if err := tx.Create(&m).Error; err != nil {
 		tx.Rollback()
+		panic(err)
 	}
 }

runner/runner.go

@@ -1,7 +1,6 @@
 package runner
 
 import (
-	"fmt"
 	"sort"
 
 	"github.com/jinzhu/gorm"
@@ -29,7 +28,6 @@ func (r *Runner) Run() {
 	for _, migraine := range r.Migs {
 		length := len(persisted)
 		i := sort.Search(length, func(i int) bool { return persisted[i].Version == migraine.Version })
-		fmt.Println(i)
 		if i == length {
 			migraine.Run(r.Db)
 		}