Fix some processes missing from "Attach to Process (Unity)"

[rigdern]

Problem

When using "Debug -> Attach to Process (Unity)...", my Unity process is not shown. Here's a screenshot:

Root cause

It seems that my Unity player data string has a slightly different format than dnSpy expects which causes its regex to fail on it.

In the debugger, I can see that my Unity process's player data string is:

[IP] 10.0.1.10 [Port] 55000 [Flags] 2 [Guid] 886973232 [EditorId] 0 [Version] 1048832 [Id] WindowsPlayer(2,Rigderns-PC) [Debug] 1 [PackageName] WindowsPlayer [ProjectName] <no name>

TryParseUnityPlayerData bails here because the value it parsed for machine doesn't match Dns.GetHostName():

• machine: "2,Rigderns-PC"
• Dns.GetHostName(): "Rigderns-PC"

Solution

I updated the regex to account for the possibility of a number and comma preceding the machine name. I verified "machine" is parsed properly regardless of whether it is preceded by a number. Examples:

• For WindowsPlayer(2,Rigderns-PC), "machine" is parsed as Rigderns-PC
• For WindowsPlayer(Rigderns-PC), "machine" is parsed as Rigderns-PC

(If there's test infrastructure in place, let me know and I can add some tests for this.)

I also verified that my Unity process is now listed in the "Attach to Process (Unity)" window.

[ElektroKill]

Hi,

Thanks for the contribution! Were you perhaps able to figure out why your version of the Unity player had the additional number in the data string and what is the purpose of this additional number?

Other than that, LGTM!

[rigdern]

No, unfortunately I couldn't find any official documentation about the Unity player data string format.

These are the mentions of the player data string that I found but none of them give insights on the meaning on that part of it:

• Unity manual
  • Gives an example player data string in the section "Ensure the device has only one active network interface" but doesn't explain its meaning: Unity - Manual: Debugging C# code in Unity (unity3d.com)
• Code from the Unity-Technologies GitHub org
  • PlayerConnection.PlayerInfo.Parse. Parses the Player string but doesn't parse the "Id" field in detail or communicate what it means.
  • Tests for PlayerConnection.PlayerInfo.Parse