Skip to content

Commit

Permalink
Fix caption buttons on multi monitor setups
Browse files Browse the repository at this point in the history
  • Loading branch information
@ElektroKill
ElektroKill committed Oct 31, 2024
1 parent cf10ad9 commit f0c90c2
Show file tree
Hide file tree
Showing 5 changed files with 260 additions and 621 deletions.
255 changes: 250 additions & 5 deletions dnSpy/dnSpy.Contracts.DnSpy/Controls/MetroWindow.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@ You should have received a copy of the GNU General Public License

using System;
using System.Diagnostics;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Windows;
using System.Windows.Controls;
using System.Windows.Controls.Primitives;
using System.Windows.Input;
using System.Windows.Interop;
using System.Windows.Media;
Expand Down Expand Up @@ -104,21 +106,33 @@ static Size GetDpi_Win81(IntPtr hWnd) {
return new Size(dpiX, dpiY);
}

struct RECT {
public int left, top, right, bottom;
RECT(bool dummy) => left = top = right = bottom = 0;// disable compiler warning
}

[DllImport("user32", SetLastError = true)]
static extern IntPtr MonitorFromWindow(IntPtr hwnd, uint dwFlags);
[DllImport("shcore", SetLastError = true)]
static extern int GetDpiForMonitor(IntPtr hmonitor, int dpiType, out int dpiX, out int dpiY);

static readonly DependencyPropertyKey uiElementIsMouseOverPropertyKey =
(DependencyPropertyKey)typeof(UIElement).GetField("IsMouseOverPropertyKey", BindingFlags.NonPublic | BindingFlags.Static)!.GetValue(null)!;
static readonly DependencyPropertyKey buttonIsPressedPropertyKey =
(DependencyPropertyKey)typeof(ButtonBase).GetField("IsPressedPropertyKey", BindingFlags.NonPublic | BindingFlags.Static)!.GetValue(null)!;

private Visual? minimizeButton;
private Visual? maximizeButton;
private Visual? closeButton;

int WM_DPICHANGED_counter = 0;
IntPtr WndProc(IntPtr hwnd, int msg, IntPtr wParam, IntPtr lParam, ref bool handled) {
const int WM_DPICHANGED = 0x02E0;
const int WM_MOUSEHWHEEL = 0x020E;
const int WM_NCHITTEST = 0x0084;
const int WM_NCMOUSELEAVE = 0x02A2;
const int WM_NCLBUTTONDOWN = 0x00A1;
const int WM_NCLBUTTONUP = 0x00A2;
const int WM_MOUSELEAVE = 0x02A3;

const nint HTCLOSE = 20;
const nint HTMAXBUTTON = 9;
const nint HTMINBUTTON = 8;

if (msg == WM_DPICHANGED) {
if (WM_DPICHANGED_counter != 0)
Expand Down Expand Up @@ -162,6 +176,139 @@ IntPtr WndProc(IntPtr hwnd, int msg, IntPtr wParam, IntPtr lParam, ref bool hand
}
}

var hitPoint = new Point((short)lParam, (short)((uint)lParam >> 16));

var result = IntPtr.Zero;
if (minimizeButton is not null) {
var hitResult = VisualTreeHelper.HitTest(minimizeButton, minimizeButton.PointFromScreen(hitPoint));
if (hitResult is not null) {
minimizeButton.SetValue(uiElementIsMouseOverPropertyKey, true);
handled = true;
result = HTMINBUTTON;
}
else {
minimizeButton.SetValue(uiElementIsMouseOverPropertyKey, false);
if (minimizeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, false);
}
}
if (maximizeButton is not null) {
var hitResult = VisualTreeHelper.HitTest(maximizeButton, maximizeButton.PointFromScreen(hitPoint));
if (hitResult is not null) {
maximizeButton.SetValue(uiElementIsMouseOverPropertyKey, true);
handled = true;
result = HTMAXBUTTON;
}
else {
maximizeButton.SetValue(uiElementIsMouseOverPropertyKey, false);
if (maximizeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, false);
}
}
if (closeButton is not null) {
var hitResult = VisualTreeHelper.HitTest(closeButton, closeButton.PointFromScreen(hitPoint));
if (hitResult is not null) {
closeButton.SetValue(uiElementIsMouseOverPropertyKey, true);
handled = true;
result = HTCLOSE;
}
else {
closeButton.SetValue(uiElementIsMouseOverPropertyKey, false);
if (closeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, false);
}

}
return result;
}

if (msg == WM_NCLBUTTONDOWN) {
var hitPoint = new Point((short)lParam, (short)((uint)lParam >> 16));

if (minimizeButton is not null) {
var hitResult = VisualTreeHelper.HitTest(minimizeButton, minimizeButton.PointFromScreen(hitPoint));
if (hitResult is not null) {
if (minimizeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, true);
handled = true;
return IntPtr.Zero;
}
}
if (maximizeButton is not null) {
var hitResult = VisualTreeHelper.HitTest(maximizeButton, maximizeButton.PointFromScreen(hitPoint));
if (hitResult is not null) {
if (maximizeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, true);
handled = true;
return IntPtr.Zero;
}
}
if (closeButton is not null) {
var hitResult = VisualTreeHelper.HitTest(closeButton, closeButton.PointFromScreen(hitPoint));
if (hitResult is not null) {
if (closeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, true);
handled = true;
return IntPtr.Zero;
}
}
return IntPtr.Zero;
}

if (msg == WM_NCLBUTTONUP) {
if (minimizeButton is ButtonBase minBtn) {
bool shouldClick = (bool)minBtn.GetValue(buttonIsPressedPropertyKey.DependencyProperty);
minBtn.SetValue(buttonIsPressedPropertyKey, false);
if (shouldClick) {
minBtn.RaiseEvent(new RoutedEventArgs(ButtonBase.ClickEvent, minBtn));
ExecuteCommand(minBtn);
}

handled = true;
}
if (maximizeButton is ButtonBase maxBtn) {
bool shouldClick = (bool)maxBtn.GetValue(buttonIsPressedPropertyKey.DependencyProperty);
maxBtn.SetValue(buttonIsPressedPropertyKey, false);
if (shouldClick) {
maxBtn.RaiseEvent(new RoutedEventArgs(ButtonBase.ClickEvent, maxBtn));
ExecuteCommand(maxBtn);
}

handled = true;
}
if (closeButton is ButtonBase closeBtn) {
bool shouldClick = (bool)closeBtn.GetValue(buttonIsPressedPropertyKey.DependencyProperty);
closeBtn.SetValue(buttonIsPressedPropertyKey, false);
if (shouldClick) {
closeBtn.RaiseEvent(new RoutedEventArgs(ButtonBase.ClickEvent, closeBtn));
ExecuteCommand(closeBtn);
}

handled = true;
}

return IntPtr.Zero;
}

if (msg == WM_NCMOUSELEAVE || msg == WM_MOUSELEAVE) {
if (minimizeButton is not null) {
minimizeButton.SetValue(uiElementIsMouseOverPropertyKey, false);
if (minimizeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, false);
}

if (maximizeButton is not null) {
maximizeButton.SetValue(uiElementIsMouseOverPropertyKey, false);
if (maximizeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, false);
}

if (closeButton is not null) {
closeButton.SetValue(uiElementIsMouseOverPropertyKey, false);
if (closeButton is ButtonBase button)
button.SetValue(buttonIsPressedPropertyKey, false);
}

return IntPtr.Zero;
}

Expand Down Expand Up @@ -193,6 +340,20 @@ private protected virtual bool HandleHorizontalScroll(IInputElement element, sho
return false;
}

private static void ExecuteCommand(ICommandSource commandSource) {
var command = commandSource.Command;
if (command is null)
return;
object commandParameter = commandSource.CommandParameter;
if (command is RoutedCommand routedCommand) {
var target = commandSource.CommandTarget ?? commandSource as IInputElement;
if (routedCommand.CanExecute(commandParameter, target))
routedCommand.Execute(commandParameter, target);
}
else if (command.CanExecute(commandParameter))
command.Execute(commandParameter);
}

/// <summary>
/// Gets the DPI
/// </summary>
Expand Down Expand Up @@ -266,6 +427,90 @@ public ImageReference SystemMenuImage {
set => SetValue(SystemMenuImageProperty, value);
}

/// <summary>
/// The DependencyProperty of IsMinimumButton property
/// </summary>
public static readonly DependencyProperty IsMinimizeButtonProperty =
DependencyProperty.RegisterAttached("IsMinimizeButton", typeof(bool), typeof(MetroWindow), new FrameworkPropertyMetadata(false, OnIsMinimizeButtonChanged));

/// <summary>
/// Get value of IsMinimumButton property
/// </summary>
/// <param name="obj"></param>
/// <returns></returns>
public static bool GetIsMinimizeButton(DependencyObject obj) => (bool)obj.GetValue(IsMinimizeButtonProperty);

/// <summary>
/// Set value of IsMinimumButton property
/// </summary>
/// <param name="obj"></param>
/// <param name="value"></param>
public static void SetIsMinimizeButton(DependencyObject obj, bool value) => obj.SetValue(IsMinimizeButtonProperty, value);

static void OnIsMinimizeButtonChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) {
if (d is not Visual v)
return;
if (GetWindow(d) is not MetroWindow win)
return;
win.minimizeButton = v;
}

/// <summary>
/// The DependencyProperty of IsMaximumButton property
/// </summary>
public static readonly DependencyProperty IsMaximizeButtonProperty =
DependencyProperty.RegisterAttached("IsMaximizeButton", typeof(bool), typeof(MetroWindow), new FrameworkPropertyMetadata(false, OnIsMaximizeButtonChanged));

/// <summary>
/// Get value of IsMaximumButton property
/// </summary>
/// <param name="obj"></param>
/// <returns></returns>
public static bool GetIsMaximizeButton(DependencyObject obj) => (bool)obj.GetValue(IsMaximizeButtonProperty);

/// <summary>
/// Set value of IsMaximumButton property
/// </summary>
/// <param name="obj"></param>
/// <param name="value"></param>
public static void SetIsMaximizeButton(DependencyObject obj, bool value) => obj.SetValue(IsMaximizeButtonProperty, value);

static void OnIsMaximizeButtonChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) {
if (d is not Visual v)
return;
if (GetWindow(d) is not MetroWindow win)
return;
win.maximizeButton = v;
}

/// <summary>
/// The DependencyProperty of IsCloseButton property
/// </summary>
public static readonly DependencyProperty IsCloseButtonProperty =
DependencyProperty.RegisterAttached("IsCloseButton", typeof(bool), typeof(MetroWindow), new FrameworkPropertyMetadata(false, OnIsCloseButtonChanged));

/// <summary>
/// Get value of IsCloseButton property
/// </summary>
/// <param name="obj"></param>
/// <returns></returns>
public static bool GetIsCloseButton(DependencyObject obj) => (bool)obj.GetValue(IsCloseButtonProperty);

/// <summary>
/// Set value of IsCloseButton property
/// </summary>
/// <param name="obj"></param>
/// <param name="value"></param>
public static void SetIsCloseButton(DependencyObject obj, bool value) => obj.SetValue(IsCloseButtonProperty, value);

static void OnIsCloseButtonChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) {
if (d is not Visual v)
return;
if (GetWindow(d) is not MetroWindow win)
return;
win.closeButton = v;
}

/// <summary>
/// Maximized element property
/// </summary>
Expand Down
18 changes: 0 additions & 18 deletions dnSpy/dnSpy/Lib/EleCho.WpfSuite/Utilities/WindowOption.NativeMethods.cs
View file

This file was deleted.

Loading

0 comments on commit f0c90c2

Please sign in to comment.