Add a generic script for deploying WMAgent inside a virtual environment. #11624
Conversation
|
Jenkins results:
|
|
Jenkins results:
|
There was a problem hiding this comment.
@todor-ivanov as we discussed this week, I'd rather have someone from T0 giving this script a try and providing us with feedback.
Nonetheless, I left a few relevant comments along the code that you might want to address before collecting feedback.
|
Hi @amaltaro I think I have addressed all your comments. Could you please take another look I will give him the list of all the OS packages that may be needed for this setup. |
|
Jenkins results:
|
|
Jenkins results:
|
There was a problem hiding this comment.
@todor-ivanov please see a few extra comments inline. Once the relevant changes are made, we could then ask German to have another look and try this out.
|
hi @amaltaro I have addressed all your comments and tested the script. Please take another look |
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
hi @LinaresToine there was a dedicated effort from both of us lately in the form of hands on meetings and redeployment && readjustments in replay agents etc. There are still things to be done of course, like the oracle functionalities, which are about to come later during the completion of the meta issue about the full containerization of the WMAgents: #11314 && #11720 , but they won't require any further deployments or tests related to the functionalities provided with this script here. I'd like to close the issue #11617, which is basically for confirming that the so provided script here make things to happen and we are capable of having a generic WMAgent deployment with it. Which is something we did prove with you during our meetings. If you agree with me, we should ask from @amaltaro for final approval and we should merge the script and close the issue. |
|
@todor-ivanov I would suggest to resolve the review I left weeks ago. Second, let's squash those commits to the most meaningful situation (i.e., it does not need to be 1 commit only, but let's squash unneeded commit messages). |
Change mode to 755 from wmagent-venv-deploy.sh Fix python executable link Remove setupDependencies for run from source mode && Fix outdated Rucio links && Fix help bool flags Substitute export command with _addWMCoreVenvVar function && Add X509 variables to the environment. Removing serviceList && Removing setupRucio && Cloning CMSKubernetes from dmwm Catchup with WMAgent init changes Rename wmagent-venv-deploy to deploy-wmagent-venv.sh ReviewComments && Fix missing tag param && Remove _realPath && Remove sudo commands
todor-ivanov
force-pushed
the
feature_Deploy_WMAgentVenv_fix-11617
branch
from
36a089a
to
502b0b2
Compare
|
Jenkins results:
|
|
Jenkins results:
|
|
@amaltaro I did address all your comments and squashed all the commits, If you find it ok now, lets merge this. |
Fixes #11617
Status
ready
Description
With the current script we provide a method for implementing the same set of steps as done during the deployment process inside the WMAgent docker image, but inside a well contained virtual environment. The end result should be a runtime environment equal to the one inside the Docker image.
NOTE: All Os dependencies need to be resolved in advance
NOTE: Here follow some instructions on how to deploy and run the agent:
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
dmwm/CMSKubernetes#1364
External dependencies / deployment changes
dmwm/CMSKubernetes#1364
Once the above PR in CMSkubernetes is merged we should proceed and fix the following lines in this script before merging it:
TODO:
To change
to