-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WMAgent: Implement all Oracle functionalities needed for the WMAgent initialization #11720
Comments
Just to log here where I stand with the progress on this issue: Following our Oracle contact's advice from last week, I am currently testing the possibilities to fetch all user objects from the database and to create a comparison view for the initial and current states. :
Again following her advice: If we need to generate and compare definition of the objects:
or
|
And here is where we stand with the current issue:
FYI @amaltaro @khurtado - please read the all 3 bullets of this long log printout from bellow. Here is the proof of concept:
|
Thanks Todor. I understand that some of the oracle checks are still to be implemented, such that we don't have to hit all those exceptions when creating tables in an initialized database, right? BTW, I had to edit your previous comment because you dumped too much information in GH, like DN and db connection string, which IMO does not need to be shared here. |
Thanks @amaltaro
Thanks.
That is correct. But those which are related to the schema validation features, I am about to separate in another issue and we will work on them later. This way the new functionality we add would not stand as a blocker for the T0 team and for us delivering a fully functional Wmagent container. |
It is All done and tested now. Waiting for the review of: dmwm/CMSKubernetes#1451 The only bit left behind is the proper implementation of the schema validation for Oracle. But since I'd like to have this whole mechanism improved for both MAriaDB and Oracle agents, I created a separate issue: #11925 for this but have not categorized its priority. I'll let others do that. I have stopped those checks for the Oracle agents in the code, such that the work on this feature does not become a blocker for T0 agents or for us to deliver the containerized model before the end of Q1. |
@todor-ivanov I left my review in the changes you provided in the CMSKubernetes repository. Please also update the description of this issue accordingly, e.g.: this issue has been closed but no changes have been provided to Given the impact of such changes, I would like to ask to wait for a final review approval, before merging changes in. In addition, such changes are likely better to have 2 reviewers. |
Impact of the new feature
WMAgent
Fixed by: dmwm/CMSKubernetes#1451
Is your feature request related to a problem? Please describe.
This issue is a followup on #11627 and is part of #11314
While working on the WMAgent initialization process we were focusing mostly on separating the MariaDB database from the agent image and once this was done we started adding new functionalities such as:
wma_init
The tests from above are based on the new service model and are implemented mostly for MariaDB while the Oracle implementation drag behind. The current issue is supposed to list all functions that need to have their oracle counterpart developed and also to track their development and testing.
Here follows the list:
At
manage
script:init_wmagent
clean_oracle
clean_all
(to just referenceclean_oracle
)At
manage-common.sh
:_status_of_oracle
(only test is needed)_sql_write_agentid
_sql_db_isclean
_sql_dbid_valid
_sql_dumpSchema
_exec_oracle
Describe the solution you'd like
The list of the above functions to be implemented
Describe alternatives you've considered
None - It is a must do
Additional context
Depends on:
Part of the following meta issue:
The text was updated successfully, but these errors were encountered: