init.sh and manage-common.sh fixes for successful initialization #1457
Conversation
|
@LinaresToine your PR is trying to revert changes from another one: This may have happened because you forgot to update your local branch before creating the PR. |
LinaresToine
force-pushed
the
PypiDEploymentChanges
branch
from
4db9915
to
69fcb2e
Compare
|
@todor-ivanov I fixed the PR. |
There was a problem hiding this comment.
Hi @LinaresToine The changes look good. There was only one extra line which I commented inline. Please take a look.
There was a problem hiding this comment.
The _check_mounts() function crashes without the return true statement in the beginning of the function.
It was one of the changes I was attempting to revert in the original PR. @todor-ivanov
There was a problem hiding this comment.
@LinaresToine I fail to relate this message to any of the action we took last time. Maybe it was something from an earlier stage. Could you please remind me?
There was a problem hiding this comment.
Indeed, we never talked about this part. What I see when running the init.sh script in this PR is that the _check_mounts() function is returning false. However, the version of the script we were using during our last meeting has that function returning true by force, so we didnt see the issue then
There was a problem hiding this comment.
hi @LinaresToine thanks for reminding me that ... I'll see what can be done.
|
@todor-ivanov @LinaresToine is this PR still relevant? Perhaps it has all been integrated into #1466? |
|
The changes in this PR have been implemented. I believe we can close this one. |
PR to fix initialization issues pointed out by @todor-ivanov in dmwm/WMCore#11890 (comment)