Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation edits for FAQ and Match Variables sections #81

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

jeannly
Copy link
Contributor

@jeannly jeannly commented Aug 29, 2022

For issue #79

I've tried to keep wording the same where possible and relevant, but apologies if it's been changed too much.
If these edits are okay, I'd like to make more in future when I find the time, editing each page from the top down:

image

I only made it from FAQs to Indicators so far. If there's any issues with the edits, feedback is much appreciated

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dmulyalin
Copy link
Owner

Awesome work! I wish I could write docs up to same level :)

If you could fix small typo I spotted, would be happy to merge it and push to readthedocs.


Above is a default, generalized behavior that (so far) works for all cases, as items always can be
This is the default, generalized behaviour that (so far) works for all cases, as items always can be
Copy link
Contributor Author

@jeannly jeannly Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x behaviour -> ✓ behavior

@jeannly
Copy link
Contributor Author

jeannly commented Aug 30, 2022

Thanks 😄! Although I'm not sure which typo you're referring to - is it that one (line 21)?

@dmulyalin dmulyalin merged commit 786643c into dmulyalin:master Aug 30, 2022
@dmulyalin
Copy link
Owner

Merged and pushed to read the docs.

Appreciate the efforts, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants