Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DMN 1.5] Add tests for equality operators in positive unary tests to the TCK suite #545

Closed
wants to merge 2 commits into from

Conversation

kbowers-ibm
Copy link

@kbowers-ibm kbowers-ibm commented Feb 15, 2023

Adding tests for positive unary tests.

@kbowers-ibm kbowers-ibm marked this pull request as ready for review February 16, 2023 08:50
@baldimir
Copy link
Collaborator

Thanks Kennedy. If the group agree to merge this, it needs to be done after the current master is branched for DMN 1.4.

@baldimir baldimir changed the base branch from master to dmn1.5 February 16, 2023 13:16
@baldimir
Copy link
Collaborator

@dmn-tck/contributors please review

@SimonRinguette
Copy link
Contributor

Tested on the Trisotech engine and it works.

Not sure why this would go to dmn-tck:dmn1.5 instead of master. because its DMN 1.3

@opatrascoiu
Copy link
Contributor

I think is because support for the operators = and != in simple positive unary test (before endpoints) was added in DMN 1.5 https://issues.omg.org/browse/DMN15-108

@SimonRinguette
Copy link
Contributor

Make sense

@baldimir baldimir changed the title kie-issues#111 Add tests for equality operators in positive unary tests to the TCK suite [DMN 1.5] Add tests for equality operators in positive unary tests to the TCK suite Nov 16, 2023
@dsntk
Copy link
Contributor

dsntk commented Jan 15, 2024

There are already tests for 1131 in main. Test case directory and file names have to be adjusted. Otherwise existing tests will be overridden.

@baldimir
Copy link
Collaborator

I will fix it. Thanks for noticing this.

@opatrascoiu
Copy link
Contributor

The tests look good to me apart from the filename (1131 is already taken by another test case)

@StrayAlien
Copy link
Contributor

I think these cases are already covered in "0072 feel in tests".

@opatrascoiu
Copy link
Contributor

@StrayAlien The == and != are not covered as they were introduced in DMN 1.5. How about we add tests for == and != in 0072 to keep all trhe in tests in one place?

@StrayAlien
Copy link
Contributor

StrayAlien commented Jun 1, 2024

Thanks @opatrascoiu . That what this PR is for: #668. It asserts on those new operators for FEEL types - except list because this is still uncertain I think. (as well as uncommenting some null tests we had in there to see if they now are valid)

@opatrascoiu
Copy link
Contributor

I checked the tests in PR #668 and they cover the ones here.

@kbowers-ibm @baldimir I think it makes sense to close this MR and focus the review on the one mentioned by @StrayAlien as it groups the test cases for unary tests in an already existing test file.

@baldimir baldimir closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants