-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DMN 1.5] Add tests for equality operators in positive unary tests to the TCK suite #545
Conversation
Thanks Kennedy. If the group agree to merge this, it needs to be done after the current master is branched for DMN 1.4. |
@dmn-tck/contributors please review |
Tested on the Trisotech engine and it works. Not sure why this would go to |
I think is because support for the operators = and != in simple positive unary test (before endpoints) was added in DMN 1.5 https://issues.omg.org/browse/DMN15-108 |
Make sense |
There are already tests for 1131 in main. Test case directory and file names have to be adjusted. Otherwise existing tests will be overridden. |
I will fix it. Thanks for noticing this. |
The tests look good to me apart from the filename (1131 is already taken by another test case) |
I think these cases are already covered in "0072 feel in tests". |
@StrayAlien The == and != are not covered as they were introduced in DMN 1.5. How about we add tests for == and != in 0072 to keep all trhe in tests in one place? |
Thanks @opatrascoiu . That what this PR is for: #668. It asserts on those new operators for FEEL types - except list because this is still uncertain I think. (as well as uncommenting some null tests we had in there to see if they now are valid) |
I checked the tests in PR #668 and they cover the ones here. @kbowers-ibm @baldimir I think it makes sense to close this MR and focus the review on the one mentioned by @StrayAlien as it groups the test cases for unary tests in an already existing test file. |
Adding tests for positive unary tests.