Add esbuild to the list of available bundlers #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized the PR is missing a couple of things:
|
|
Both issues should be solved in the last two commits. @dmmulroy if everything's looking good to you, do you think we could publish a new version? 🥺 |
dmmulroy
pushed a commit
that referenced
this pull request
Jul 26, 2024
* add esbuild * esbuild: add live reload * fix esbuild readme template
dmmulroy
added a commit
that referenced
this pull request
Jul 26, 2024
* fix key errors, bump version * Move index into public/index (#105) * fix project names with nested dirs (#99) * fix project names with nested dirs * disallow names including '/' * fix case where names have trailing '/' * Add esbuild to the list of available bundlers (#107) * add esbuild * esbuild: add live reload * fix esbuild readme template * fix some typos --------- Co-authored-by: David Sancho <[email protected]> Co-authored-by: mbpowers <[email protected]> Co-authored-by: Javier Chávarri <[email protected]>
dmmulroy
added a commit
that referenced
this pull request
Jul 26, 2024
* fix key errors * v.1.2.0 (#108) * fix key errors, bump version * Move index into public/index (#105) * fix project names with nested dirs (#99) * fix project names with nested dirs * disallow names including '/' * fix case where names have trailing '/' * Add esbuild to the list of available bundlers (#107) * add esbuild * esbuild: add live reload * fix esbuild readme template * fix some typos --------- Co-authored-by: David Sancho <[email protected]> Co-authored-by: mbpowers <[email protected]> Co-authored-by: Javier Chávarri <[email protected]> --------- Co-authored-by: David Sancho <[email protected]> Co-authored-by: mbpowers <[email protected]> Co-authored-by: Javier Chávarri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ditto.
esbuild is fast (building cma app takes 58ms), and quite simple to set up. It also works very similarly in watch / dev mode than in regular build mode, which could be beneficial for integrations like the one spec'ed in #83.
I wasn't sure how to test, I just followed the instructions in CONTRIBUTING.md and created a new template. Then made sure the scripts in package.json worked: