[R] Move more functions to array interface #9824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
From comment #9734 (comment)
This PR moves more R functions to the new array interface.
Here I've created a copy-paste of the matrix function for 1d vectors. I'm not sure why it needs
[[nodiscard]]
qualifiers though.Along the way, it also solves a potential memory leak in the previous PR in which the call to
CHECK_CALL
could potentially lead to leaked memory ofstd::string
objects that are used for the array interface.