Workaround poll on macos. #9596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rongou . |
rongou
reviewed
Sep 20, 2023
| @@ -549,7 +549,7 @@ AllreduceBase::TryAllreduceTree(void *sendrecvbuf_, | |||
| break; | |||
| } | |||
| // select must return | |||
| auto poll_res = watcher.Poll(timeout_sec); | |||
| auto poll_res = watcher.Poll(timeout_sec, false); // fail on macos | |||
There was a problem hiding this comment.
What does "fail on macox" mean? The old code was failing or the new code?
There was a problem hiding this comment.
The old code was failing but did not check. The new code checks for those errors
.There was a problem hiding this comment.
It seems those errors don't affect the actual output on macos. The underlying reason however, is unclear to me. Maybe I should try to get a mac device somehow.
There was a problem hiding this comment.
You can start a macos instance on aws.
There was a problem hiding this comment.
I will make more checks for macos once the old rabit code can be replaced.
rongou
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.