[pyspark] support gpu transform #9542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Sep 5, 2023
Comment on lines
+95
to
+100
| try: | ||
| import cupy | ||
|
|
||
| return True | ||
| except ImportError: | ||
| return False |
There was a problem hiding this comment.
The test for cuDF availability originally had the comment:
# Checking by `importing` instead of check `importlib.util.find_spec("cudf") is not None`
WeichenXu123 marked this conversation as resolved.
# because user might install cudf successfully but importing cudf raises issues (e.g. saying
# running on mismatched cuda version)
which to me was weird, that's a mismanaged environment and I'm not sure it's necessary for xgboost to work around it (or even a good idea to workaround anything since users with cuDF installed might expect GPU to be used).
python-package/xgboost/spark/core.py
Outdated
Comment on lines
245
to
250
| def set_device(self, value: str) -> "_SparkXGBParams": | ||
| """Set device (cpu, cuda, gpu)""" | ||
| assert value in ("cpu", "cuda", "gpu") | ||
| self.set(self.device, value) | ||
| return self | ||
|
|
There was a problem hiding this comment.
We have a check here:
xgboost/python-package/xgboost/core.py
Line 284 in 3b9e590
Line 95 in 3b9e590
There was a problem hiding this comment.
Seems _check_distributed_params just checks the type of the value, it seems we also need to restrict it to be one of (CPU ,GPU, cuda)
wbo4958
force-pushed
the
gpu-transform
branch
from
accf7e1
to
f74fccc
Compare
trivialfis
reviewed
Sep 6, 2023
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Sep 7, 2023
--------- Co-authored-by: Jiaming Yuan <[email protected]>
trivialfis
added a commit
that referenced
this pull request
Sep 7, 2023
--------- Co-authored-by: Bobby Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to support gpu transform. @WeichenXu123 @trivialfis Please help to review this PR. Thx