Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] reformat build scripts #9540

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

jameslamb
Copy link
Contributor

Proposes some small changes to the build scripts in the R package, with to make them a bit easier to read (in my opinion) and to make diffs slightly easier to review (via breaking long blocks of arguments out into one argument per line).

this PR is only moving code around and should not change behavior.

I'm sorry for a style-only PR, but I do really think this will make it a bit easier for contributors to understand how the R package is built. If you'd rather not review such style-only PRs, please let me know and I'll stop submitting things like this.

Notes for Reviewers

We've been using similar formatting in {lightgbm} for a few years without issue, e.g. https://github.com/microsoft/LightGBM/blob/1881a501782e0ab1e7618b3ab6ff8871ee311860/R-package/src/Makevars.win.in#L18-L22.

In that project, we also use cmakelint to standardize formatting in CMakeLists.txt and *.cmake scripts... do you have any interest in adopting that tool here in XGBoost? If so I'd be happy to put up a separate PR proposing its use in CI here.

Thanks for your time and consideration.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning up the code!

but I do really think this will make it a bit easier for contributors to understand how the R package is built

I agree. Small changes add up. Thank you for working on the R package.

n that project, we also use cmakelint to standardize formatting in CMakeLists.txt and *.cmake scripts

That sounds awesome!

@trivialfis trivialfis merged commit d159ee8 into dmlc:master Sep 4, 2023
21 checks passed
@jameslamb jameslamb deleted the r/build-script-formatting branch September 14, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants