Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes some small changes to the build scripts in the R package, with to make them a bit easier to read (in my opinion) and to make diffs slightly easier to review (via breaking long blocks of arguments out into one argument per line).
this PR is only moving code around and should not change behavior.
I'm sorry for a style-only PR, but I do really think this will make it a bit easier for contributors to understand how the R package is built. If you'd rather not review such style-only PRs, please let me know and I'll stop submitting things like this.
Notes for Reviewers
We've been using similar formatting in
{lightgbm}
for a few years without issue, e.g. https://github.com/microsoft/LightGBM/blob/1881a501782e0ab1e7618b3ab6ff8871ee311860/R-package/src/Makevars.win.in#L18-L22.In that project, we also use
cmakelint
to standardize formatting inCMakeLists.txt
and*.cmake
scripts... do you have any interest in adopting that tool here in XGBoost? If so I'd be happy to put up a separate PR proposing its use in CI here.Thanks for your time and consideration.