Fix inplace predict with fallback when base margin is used. #9536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy meta info from proxy DMatrix. - Use `std::call_once` to emit less warnings.
trivialfis
commented
Sep 1, 2023
| @@ -58,21 +58,6 @@ void TestInplaceFallback(Context const* ctx) { | |||
| HostDeviceVector<float>* out_predt{nullptr}; | |||
| ConsoleLogger::Configure(Args{{"verbosity", "1"}}); | |||
| std::string output; | |||
| // test whether the warning is raised | |||
There was a problem hiding this comment.
The test is removed as we are only emitting the warning once.
RAMitchell
approved these changes
Sep 4, 2023
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Sep 5, 2023
dmlc#9536) - Copy meta info from proxy DMatrix. - Use `std::call_once` to emit less warnings.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::call_onceto emit less warnings for thread-based prediction.