Support column split in GPU predictor #9343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Jun 28, 2023
trivialfis
reviewed
Jun 29, 2023
trivialfis
reviewed
Jun 29, 2023
src/predictor/gpu_predictor.cu
Outdated
| if (old_decision_size < size) { | ||
| decision_storage->resize(size); | ||
| } | ||
| if (old_decision_size != 0) { |
There was a problem hiding this comment.
Why do you use old_decision_size instead of size?
There was a problem hiding this comment.
Could you please share some insight on this?
|
@trivialfis Can this be merged? Thanks! |
trivialfis
approved these changes
Jul 2, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach is similar to the CPU predictor: first collect all the decisions at each node and whether the feature is missing locally, then do an allreduce on the bit vectors, and finally use the bit vectors to find the leaf.
Still need to do more testing in a followup.