[EM] Treat ellpack as dense matrix when there's no compression. #10870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compression info. Row stride. Add test. cleanup. Add tests. name. Cleanup. comment. used n_symbols. cleanup. Histogram. Split up tests. Write compressed. Comment. from ghist. Work on ellpack -> ghist. look into adapter case. from data. cleanup. start working on tests. check. From adapter. to ghist. dense. empty. feature groups. feature group. histogram. rename. CPU. cleanup. Enable get cut. Fix test.
cleanup. Fix. test. fix.
|
cc @rongou It's a big PR, I'm happy to do online review if needed. |
rongou
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables XGBoost to use shared memory to build histograms. In addition, it lowers memory usage and speeds up external memory for data that cannot be compressed using the ellpack format.