Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Rename ExternalDMatrix -> ExtMemDMatrix. #10849

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

trivialfis
Copy link
Member

We will have an external memory version of QuantileDMatrix, which is named ExtMemQuantileDMatrix to reflect the use of external memory with data being fetched on-demand during training instead of simply using an iterator for construction.

We will have an external memory version of `QuantileDMatrix`, which is named as
`ExtMemQuantileDMatrix` to reflect the use of external memory instead of simply using an iterator.
@trivialfis trivialfis changed the title [WIP][R] Rename ExternalDMatrix -> ExtMemDMatrix. [R] Rename ExternalDMatrix -> ExtMemDMatrix. Sep 27, 2024
@trivialfis trivialfis marked this pull request as ready for review September 27, 2024 20:32
@trivialfis
Copy link
Member Author

@david-cortes @mayer79 Could you please help take a look when you are available?

@mayer79
Copy link
Contributor

mayer79 commented Sep 28, 2024

LGTM

@trivialfis trivialfis merged commit c9f89c4 into dmlc:master Sep 28, 2024
28 of 30 checks passed
@trivialfis trivialfis deleted the ext-R-rename branch September 28, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants