Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] shade xgboost spark packages #10833

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Sep 20, 2024

This PR assembles xgboost4j.jar/xgboost4j-spark.jar into the existing xgboost4j-spark.jar and xgboost4j.jar/xgboost4j-spark.jar/xgboost4j-spark-gpu.jar into xgboost4j-spark-gpu.jar. So with this PR, user can use xgboost4j-spark.jar for xgboost cases without specifying the xgboost4j.jar explicitly. Similary to xgboost4j-spark-gpu.jar

@wbo4958
Copy link
Contributor Author

wbo4958 commented Sep 20, 2024

I did the tests manually on the local standalone cluster for both scala 2.12 and scala 2.13. All of the tests passed without any issues.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Sep 20, 2024

Hi @eordentlich, @trivialfis, Could you help review this PR, thx.

@trivialfis
Copy link
Member

I will leave the review to @eordentlich or @hcho3 .

Copy link

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jvm-packages/xgboost4j-spark-gpu/pom.xml Outdated Show resolved Hide resolved
jvm-packages/xgboost4j-spark/pom.xml Outdated Show resolved Hide resolved
@wbo4958
Copy link
Contributor Author

wbo4958 commented Sep 23, 2024

Looks like documentation needs to be updated to match these changes: https://xgboost.readthedocs.io/en/latest/jvm/xgboost_spark_migration.html#xgboost-spark-packages https://xgboost.readthedocs.io/en/latest/install.html#jvm

I will have a follow up PR to update these completely.

@trivialfis
Copy link
Member

I will have a follow up PR to update these completely.

Could you please open a tracking issue?

@wbo4958
Copy link
Contributor Author

wbo4958 commented Sep 23, 2024

Done. #10841

Copy link

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trivialfis trivialfis merged commit 2a03685 into dmlc:master Sep 24, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants