-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jvm-packages] shade xgboost spark packages #10833
Conversation
I did the tests manually on the local standalone cluster for both scala 2.12 and scala 2.13. All of the tests passed without any issues. |
Hi @eordentlich, @trivialfis, Could you help review this PR, thx. |
I will leave the review to @eordentlich or @hcho3 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like documentation needs to be updated to match these changes:
https://xgboost.readthedocs.io/en/latest/jvm/xgboost_spark_migration.html#xgboost-spark-packages
https://xgboost.readthedocs.io/en/latest/install.html#jvm
I will have a follow up PR to update these completely. |
Could you please open a tracking issue? |
Done. #10841 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR assembles xgboost4j.jar/xgboost4j-spark.jar into the existing xgboost4j-spark.jar and xgboost4j.jar/xgboost4j-spark.jar/xgboost4j-spark-gpu.jar into xgboost4j-spark-gpu.jar. So with this PR, user can use xgboost4j-spark.jar for xgboost cases without specifying the xgboost4j.jar explicitly. Similary to xgboost4j-spark-gpu.jar