[R] Fix warning about mismatched names when joining #10743
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mayer79 Could you please help review this PR when you are available? I'm not familiar with the DiagrammeR package. |
mayer79
approved these changes
Aug 26, 2024
But is that what it was supposed to be doing? |
I think yes, but I have never actively used this function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10742
ref #9810
This PR fixes a warning (which actually turn out to come from data.table, not from DiagrammeR) about mismatched column names when concatenating inputs.
I'm not 100% if this is doing what the function is meant to do though, so would be ideal if someone could take a deeper look.