Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fixups for federated tests #10389

Closed
wants to merge 3 commits into from

Conversation

crockeea
Copy link

@crockeea crockeea commented Jun 4, 2024

When I tried to run federated learning tests following the directions in https://github.com/dmlc/xgboost/blob/master/plugin/federated/README.md, I ran into several problems.

  1. The path to the tests is wrong in the README; that's fixed in this PR.
  2. All calls to run_federated_server swap the order of the first two arguments. I decided to change the order of the parameters rather than change each call to the function.
  3. run_federated_server doesn't supply the key/certificate paths when creating a FederatedTracker.

Note that I still cannot get the tests to work even with these changes; now they fail without a helpful error:

[21:45:11] Insecure federated server listening on 0.0.0.0:9091, world size 2
Traceback (most recent call last):
  File "/home/ubuntu/xgboost/tests/test_distributed/test_federated/test_federated.py", line 84, in <module>
    run_federated(with_ssl=False, with_gpu=False)
  File "/home/ubuntu/xgboost/tests/test_distributed/test_federated/test_federated.py", line 69, in run_federated
    raise Exception("Error starting Federated Learning server")
Exception: Error starting Federated Learning server

@crockeea crockeea changed the base branch from release_2.1.0 to master June 4, 2024 22:23
@trivialfis
Copy link
Member

Apologies for the slow response here. We are still working on it, and things are in flux. Will take a deeper look into these and push some documents after #9987 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants