Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error for 32-bit archs #10005

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Throw error for 32-bit archs #10005

merged 1 commit into from
Jan 24, 2024

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 23, 2024

Closes #10002

@hcho3 hcho3 requested a review from trivialfis January 24, 2024 02:32
@hcho3 hcho3 merged commit 60ec7b8 into dmlc:master Jan 24, 2024
25 of 27 checks passed
@hcho3 hcho3 deleted the drop_32bit branch January 24, 2024 21:04
@henryiii
Copy link

henryiii commented Jan 30, 2024

WebAssembly is a 32-bit arch. Pyodide includes XGBoost and is having trouble updating to CPython 3.12 due to being unable to update XGBoost.

#8964 looks like it was trying to fix 32-bit errors.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 31, 2024

@henryiii I filed #10021 to restore 32-bit support.

@henryiii
Copy link

henryiii commented Feb 1, 2024

Thanks! By the way, it's not too hard to build in Pyodide in CI as a way to test 32-bit builds. NumPy and others do it, see https://github.com/numpy/numpy/blob/main/.github/workflows/emscripten.yml or https://github.com/scikit-hep/boost-histogram/blob/develop/.github/workflows/emscripten.yaml (the later example gets the pinned values from pyodide rather than having to update several values every time something changes!). Don't know if it's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build breaks on i386
3 participants