Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Stop Windows pipeline upon a failing pytest #10003

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 23, 2024

Closes #9618

Currently, the Windows CI pipeline continues to execute even when a pytest fails. Example: https://buildkite.com/xgboost/xgboost-ci-windows/builds/4475#018d34ec-1805-4b3a-8206-e4addbae123f/2297-23796
This is because a PowerShell script doesn't stop automatically when a child process returns a non-zero exit code. See https://stackoverflow.com/a/9949909.

Fix: Explicitly check the exit code from the pytest suites and terminate the script as needed. Example: https://buildkite.com/xgboost/xgboost-ci-windows/builds/4477#018d3862-44d6-4219-8f40-7db901f8653a/4179-25710

@hcho3 hcho3 marked this pull request as draft January 23, 2024 06:05
@hcho3 hcho3 changed the title [Don't merge] [CI] Test if Windows CI can catch failing pytest [CI] Stop Windows pipeline upon a failing pytest Jan 23, 2024
@hcho3 hcho3 marked this pull request as ready for review January 23, 2024 23:10
@hcho3 hcho3 requested a review from trivialfis January 24, 2024 03:13
@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 24, 2024

@trivialfis Can you help debug the failing pytest test_device_quantile_dmatrix.py::TestQuantileDMatrix::test_check_inf ?

@trivialfis
Copy link
Member

Will look into it.

@trivialfis
Copy link
Member

There's a bug in MSVC + NVCC, it somehow enters a condition even though it's false (explicitly printed and verified to be false). Trying to come up with a workaround.

@hcho3 hcho3 merged commit c8f5d19 into dmlc:master Jan 25, 2024
24 of 27 checks passed
@hcho3 hcho3 deleted the win_error_fix branch January 25, 2024 06:54
@hcho3
Copy link
Collaborator Author

hcho3 commented Jan 25, 2024

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Failing tests are not reported accordingly on Windows.
2 participants