Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv6 support #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ipv6 support #38

wants to merge 7 commits into from

Conversation

mstebelev
Copy link

No description provided.

@mli
Copy link
Member

mli commented Jan 20, 2016

many thanks for the PR! a naive question, does this PR affect the ipv4 only case? i don't have ipv6 machines at hand so cannot test it.

@mstebelev
Copy link
Author

I tested this feature with linear.dmlc on my branch https://github.com/mstebelev/ps-lite/tree/ipv6 which is forked from v1 tag because wormhole can't be built from ps-lite/master.
It was tested on ipv6 only machines and on ipv4+ipv6 machines and it works. Don't know whether it works on ipv4 only, but i tried to make code protocol independent and likeky it works.

  1. I want to push my ipv6 branch to dmlc/ps-lite repo in order to make request in wormhole to build with ipv6. How can I do it? PR can be created between existing branches
  2. I don't know how to test my changes on master, may be you can check did I break something?

@mli
Copy link
Member

mli commented Jan 20, 2016

sorry for the mess... i'm trying to move both wormhole/linear and wormhole/difacto to into a separate project difacto. currently i'm working on the dev branch and hope to get everything done soon (better code organization and more optimization algorithms).

it would be much better to merge ipv6 into the master branch and use difacto to instead wormhole/linear after.

@BLiuBLiu
Copy link

BLiuBLiu commented Apr 7, 2016

Could you add some full demo to show how to train the Deep Learning model in ps-lite? Such as Lenet in mnist ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants