Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image classification training scripts and readme #309

Merged
merged 7 commits into from
Oct 9, 2018
Merged

Fix image classification training scripts and readme #309

merged 7 commits into from
Oct 9, 2018

Conversation

hetong007
Copy link
Member

No description provided.

@mli
Copy link
Member

mli commented Sep 12, 2018

Job PR-309-1 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/1/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Sep 14, 2018

Job PR-309-2 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/2/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Sep 15, 2018

Job PR-309-3 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/3/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Sep 18, 2018

Job PR-309-4 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/4/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Sep 19, 2018

Job PR-309-5 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/5/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Sep 20, 2018

Job PR-309-6 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/6/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@hetong007
Copy link
Member Author

Adding fix for #331

@mli
Copy link
Member

mli commented Sep 24, 2018

Job PR-309-8 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/8/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Sep 25, 2018

Job PR-309-9 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/9/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Sep 26, 2018

Job PR-309-10 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/10/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Sep 28, 2018

Job PR-309-12 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/12/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

d-li14
d-li14 reviewed Sep 28, 2018
View reviewed changes
scripts/classification/imagenet/train_imagenet.py
elif opt.label_smoothing:
hard_label = label
label = smooth(label, classes)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this label is not used now? After adding line 362 the train_metric seems to be updated with hard_label, irrelevant to the smoothed label.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label is used in loss calculation.

@mli
Copy link
Member

mli commented Sep 30, 2018

Job PR-309-13 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/13/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Oct 2, 2018

Job PR-309-14 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/14/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Oct 3, 2018

Job PR-309-15 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/15/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@mli
Copy link
Member

mli commented Oct 8, 2018

Job PR-309-18 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-309/18/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@hetong007 hetong007 merged commit fd947a9 into dmlc:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-li14 d-li14 d-li14 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hetong007 @mli @d-li14