Merge pull request #596 from leezu/fixoptional

Disable GCC v6+ -Wmaybe-uninitialized in optional.h
dmlc · Mar 3, 2020 · c8f7f9c · c8f7f9c
2 parents cce75c1 + 4e90853
commit c8f7f9c
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/include/dmlc/optional.h b/include/dmlc/optional.h
@@ -46,15 +46,25 @@ class optional {
   optional() : is_none(true) {}
   /*! \brief construct an optional object with value */
   explicit optional(const T& value) {
+#pragma GCC diagnostic push
+#if __GNUC__ >= 6
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+#endif
     is_none = false;
     new (&val) T(value);
+#pragma GCC diagnostic pop
   }
   /*! \brief construct an optional object with another optional object */
   optional(const optional<T>& other) {
+#pragma GCC diagnostic push
+#if __GNUC__ >= 6
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+#endif
     is_none = other.is_none;
     if (!is_none) {
       new (&val) T(other.value());
     }
+#pragma GCC diagnostic pop
   }
   /*! \brief deconstructor */
   ~optional() {