Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphBolt] Improve sample_neighbors() on CPU with prob/mask by 6.47%, fixing #7462 #7794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[GraphBolt] Improve sample_neighbors() on CPU with prob/mask by 6.47%, fixing #7462 #7794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc5f8a
change based on #7462
Sep 10, 2024
6a02473
remove squeeze(1)
Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion graphbolt/src/fused_csc_sampling_graph.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,7 +1412,8 @@ inline int64_t UniformPick(
/** @brief An operator to perform non-uniform sampling. */
static torch::Tensor NonUniformPickOp(
torch::Tensor probs, int64_t fanout, bool replace) {
auto positive_probs_indices = probs.nonzero().squeeze(1);
auto positive_probs_indices = probs.nonzero();
// returns a N-by-1 tensor, compatible with all data_ptr() usage below
auto num_positive_probs = positive_probs_indices.size(0);
if (num_positive_probs == 0) return torch::empty({0}, torch::kLong);
if ((fanout == -1) || (num_positive_probs <= fanout && !replace)) {
Expand Down
Loading